Skip to content

refactor: adjust prefix logic#1189

Merged
BioPhoton merged 8 commits intomainfrom
fix/nx-plugin/apply-prefix-on-all-but-root
Dec 16, 2025
Merged

refactor: adjust prefix logic#1189
BioPhoton merged 8 commits intomainfrom
fix/nx-plugin/apply-prefix-on-all-but-root

Conversation

@BioPhoton
Copy link
Collaborator

@BioPhoton BioPhoton commented Dec 15, 2025 •
edited
Loading

Includes:

  • projectPrefix fix
  • plugin config defaults

related to #1091

@nx-cloud
Copy link

nx-cloud bot commented Dec 15, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 73e44c5

Command Status Duration Result
nx run ci:code-pushup -- merge-diffs --files=/h... ✅ Succeeded 5s View ↗
nx run-many --targets=code-pushup --parallel=fa... ✅ Succeeded 1m 23s View ↗
nx run-many --targets=code-pushup --parallel=fa... ✅ Succeeded 12m 13s View ↗
nx run-many -t unit-test,int-test ✅ Succeeded 16s View ↗

☁️ Nx Cloud last updated this comment at 2025-12-16 19:09:33 UTC

@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 15, 2025 •
edited
Loading

Open in StackBlitz

@code-pushup/ci

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/ci@1189

@code-pushup/cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/cli@1189

@code-pushup/core

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/core@1189

@code-pushup/create-cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/create-cli@1189

@code-pushup/models

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/models@1189

@code-pushup/nx-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/nx-plugin@1189

@code-pushup/axe-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/axe-plugin@1189

@code-pushup/coverage-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/coverage-plugin@1189

@code-pushup/eslint-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/eslint-plugin@1189

@code-pushup/js-packages-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/js-packages-plugin@1189

@code-pushup/jsdocs-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/jsdocs-plugin@1189

@code-pushup/lighthouse-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/lighthouse-plugin@1189

@code-pushup/typescript-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/typescript-plugin@1189

@code-pushup/utils

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/utils@1189

commit: e72156b

@github-actions
Copy link
Contributor

github-actions bot commented Dec 15, 2025 •
edited
Loading

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit 1c08e38 with previous commit d1e8192.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Performance 🔴 35 🔴 45 ↑ +10.1
Documentation 🔴 35 🔴 35 ↑ +0.1
Code coverage 🟡 89 🟡 89 ↓ −0.1
Axe Accessibility 🟡 88 🟡 88 ↓ −0.1
Bug prevention 🟡 67 🟡 67 –
Code style 🟢 99 🟢 99 –
Security 🔴 43 🔴 43 –
Updates 🟡 71 🟡 71 –
Type Safety 🟡 56 🟡 56 –
Miscellaneous 🟡 67 🟡 67 –
Accessibility 🟢 92 🟢 92 –
Best Practices 🟢 100 🟢 100 –
SEO 🟢 92 🟢 92 –
👍 2 groups improved, 👎 1 group regressed, 👍 6 audits improved, 👎 1 audit regressed, 17 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Lighthouse Performance 🔴 35 🔴 45 ↑ +10.1
JSDoc coverage Documentation coverage 🔴 35 🔴 35 ↑ +0.1
Code coverage Code coverage metrics 🟡 89 🟡 89 ↓ −0.1

31 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse Total Blocking Time 🟥 1,830 ms 🟥 840 ms ↓ −54 %
Lighthouse Speed Index 🟥 7.4 s 🟥 5.8 s ↓ −21.5 %
Lighthouse Max Potential First Input Delay 🟥 1,260 ms 🟥 550 ms ↓ −55.9 %
Lighthouse First Contentful Paint 🟥 3.3 s 🟥 3.1 s ↓ −4.3 %
Lighthouse Time to Interactive 🟥 13.1 s 🟥 12.3 s ↓ −6.1 %
JSDoc coverage Variables coverage 🟥 251 undocumented variables 🟥 251 undocumented variables +0 %
Code coverage Branch coverage 🟨 87.3 % 🟨 87.2 % ↓ −0.1 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 2,059 KiB 🟩 Total size was 2,050 KiB ↓ −0.4 %
Lighthouse Minimizes main-thread work 🟥 10.3 s 🟥 6.2 s ↓ −40.3 %
Lighthouse Server Backend Latencies 🟩 1,780 ms 🟩 340 ms ↓ −81 %
Lighthouse JavaScript execution time 🟥 3.9 s 🟥 2.4 s ↓ −36.7 %
Lighthouse Largest Contentful Paint 🟥 11.9 s 🟥 10.8 s ↓ −8.8 %
Lighthouse Metrics 🟩 100% 🟩 100% ↓ −6.1 %
Lighthouse Uses efficient cache policy on static assets 🟨 30 resources found 🟨 30 resources found ↓ −0.1 %
Lighthouse Reduce unused JavaScript 🟥 Potential savings of 187 KiB 🟥 Potential savings of 189 KiB ↓ −15.1 %
Lighthouse Initial server response time was short 🟥 Root document took 710 ms 🟥 Root document took 760 ms ↑ +7.9 %
Lighthouse Avoids an excessive DOM size 🟥 2,352 elements 🟥 2,360 elements ↑ +0.3 %
TypeScript Semantic errors 🟥 2601 errors 🟥 2608 errors ↑ +0.3 %
Axe Accessibility Elements must only use supported ARIA attributes 🟩 95 elements 🟩 100 elements ↑ +5.3 %
Axe Accessibility ARIA attributes must be used as specified for the element's role 🟩 95 elements 🟩 100 elements ↑ +5.3 %
Axe Accessibility Elements must only use permitted ARIA attributes 🟩 95 elements 🟩 100 elements ↑ +5.3 %
Axe Accessibility ARIA attributes must conform to valid names 🟩 95 elements 🟩 100 elements ↑ +5.3 %
Lighthouse Network Round Trip Times 🟩 70 ms 🟩 70 ms ↑ +6.1 %
Code coverage Line coverage 🟨 84.9 % 🟨 84.9 % ↓ −0.1 %

655 other audits are unchanged.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 15, 2025 •
edited
Loading

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit 1c08e38 with previous commit d1e8192.

💼 Project nx-plugin

🤨 Code PushUp report has both improvements and regressions.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Documentation 🟡 64 🟡 65 ↑ +1.1
Code coverage 🟡 85 🟡 85 ↓ −0.3

4 other categories are unchanged.

👍 1 group improved, 👎 1 group regressed, 👍 1 audit improved, 👎 2 audits regressed

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
JSDoc coverage Documentation coverage 🟡 64 🟡 65 ↑ +1.1
Code coverage Code coverage metrics 🟡 85 🟡 85 ↓ −0.3

13 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
JSDoc coverage Variables coverage 🟥 7 undocumented variables 🟥 7 undocumented variables +0 %
Code coverage Branch coverage 🟨 76.4 % 🟨 75.6 % ↓ −1.1 %
Code coverage Line coverage 🟨 79.9 % 🟨 79.7 % ↓ −0.3 %

445 other audits are unchanged.

13 other projects are unchanged.

@github-actions github-actions bot added the 🔬 testing writing tests label Dec 15, 2025
@BioPhoton BioPhoton marked this pull request as ready for review December 15, 2025 19:58
@BioPhoton BioPhoton mentioned this pull request Dec 15, 2025
Open
13 tasks
@BioPhoton BioPhoton requested a review from matejchalk December 15, 2025 20:11
matejchalk
matejchalk approved these changes Dec 16, 2025
View reviewed changes
@BioPhoton BioPhoton enabled auto-merge (squash) December 16, 2025 18:54
@BioPhoton BioPhoton merged commit a3fc6d0 into main Dec 16, 2025
23 checks passed
@BioPhoton BioPhoton deleted the fix/nx-plugin/apply-prefix-on-all-but-root branch December 16, 2025 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matejchalk matejchalk matejchalk approved these changes

Assignees

@BioPhoton BioPhoton

Labels

🧩 nx-plugin 🔬 testing writing tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@BioPhoton @matejchalk